On Tue, 17 Jun 2025 07:24:37 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - Mark's suggestion - use "connect timeout" instead of "connection timeout"
>>  - Daniel's suggestion for the text
>
> src/java.base/share/classes/java/net/Socket.java line 629:
> 
>> 627:      * {@code timeout} specified to this method then an {@code 
>> IOException} is thrown.
>> 628:      * The {@code timeout} specified to this method is typically a 
>> timeout value that is
>> 629:      * shorter than the operating system timeout.
> 
> The previous version was a bit clearer but this version is okay too. You 
> might want to consider "is in the range of tens of seconds to ..." rather 
> than "ranges within tens of seconds to ..".

Done, I've updated the PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25690#discussion_r2151672649

Reply via email to