On Mon, 9 Jun 2025 07:39:02 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this doc-only change which proposes to add a > `@apiNote` to the `Socket.connect(SocketAddress endpoint, int timeout)` > method? This addresses https://bugs.openjdk.org/browse/JDK-7116990. > > As noted in that issue, users can find it surprising that when the > `Socket.connect(...)` method is called with a `timeout` value, then if that > timeout value happens to be greater than the connect timeout that operating > systems typically impose, then a `IOException` gets thrown instead of the > `SocketTimeoutException`. The change in this PR proposes to add a `@apiNote` > which explains this current behaviour. > > If this requires a CSR, I'll open one once we settle on the proposed text. This pull request has now been integrated. Changeset: 2f63d3ae Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/2f63d3aee555762bfaea2a77bf543a32ca43f069 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod 7116990: (spec) Socket.connect(addr,timeout) not clear if IOException because of TCP timeout Reviewed-by: alanb, dfuchs ------------- PR: https://git.openjdk.org/jdk/pull/25690
