On Sat, 21 Jun 2025 09:03:10 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Feedback changes and renaming field to match nomenclature of JEP 220. > > src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java > line 87: > >> 85: if (resourceNode == null) { >> 86: if (path == null) { >> 87: throw new IOException("cannot connect to jrt:/" + >> module); > > Maybe we can make this `module.isEmpty() || (path == null)` as it needs a > non-empty module and resource to connect. Good point. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25871#discussion_r2161334893