On Tue, 24 Jun 2025 14:48:31 GMT, Alan Bateman <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Remove redundant fast-path check.
>> - Change method name.
>> - Feedback changes (maybe some still to be done).
>
> src/java.base/share/classes/sun/net/www/protocol/jrt/JavaRuntimeURLConnection.java
> line 113:
>
>> 111: public long getContentLengthLong() {
>> 112: // Note: UncheckedIOException is thrown by the Node subclass in
>> 113: // ExplodedImage (this not obvious, so worth calling out).
>
> This protocol handler is for images build, not exploded builds.
> ImageReaderFactory.getImageReader will fail if you attempt it with an
> exploded build. So I don't think we need this comment or the catch of UIOE.
Roger suggested I add the catch for the `UncheckedIOException` because of it.
Maybe chat with him to see if this could somehow end up seeing an ExplodedImage
build?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25871#discussion_r2164354818
