On Wed, 18 Jun 2025 12:53:56 GMT, David Beaumont <d...@openjdk.org> wrote:
> Simplifying JavaRuntimeURLConnection to avoid accidentally returning > non-resource data to users. > > This change has the following distinct parts: > 1. Refactor code to use Node instead of directly accessing low level > ImageLocation type. > 2. Remove unnecessary use of "Resource" interface and related URL generation > code (completely unreachable). > 3. Adding comments explaining why there's a non-obvious distinction in how > module and resource names are treated with respect to URL percent encoding. > 4. Small constructor logic simplification (module name cannot be null anymore) > 5. Small simplification around 'READER' use, since it is impossible for that > to ever be null (other users of ImageReaderFactory already assume it could > never be null, and code path analysis agrees). > 6. Adding tests for the non-resource cases. > 7. Adding extra test data to check the behaviour with respect to things like > percent escaping (previously untested). > 8. Adding TODO comments for things I could do in this PR or later (reviewer > opinions welcome). This pull request has now been integrated. Changeset: ba0c1223 Author: David Beaumont <david.beaum...@oracle.com> Committer: Roger Riggs <rri...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/ba0c12231b0f5b680951e75765b5d292f31a2cbc Stats: 132 lines in 2 files changed: 38 ins; 59 del; 35 mod 8359808: JavaRuntimeURLConnection should only connect to non-directory resources Reviewed-by: alanb, rriggs ------------- PR: https://git.openjdk.org/jdk/pull/25871
