On Wed, 30 Jul 2025 09:32:40 GMT, Volkan Yazici <[email protected]> wrote:
>> test/jdk/java/net/httpclient/FileChannelPublisherTest.java line 168: >> >>> 166: } >>> 167: >>> 168: private static BlockingQueue<byte[]> >>> addRequestBodyConsumingServerHandler( >> >> Nit - instead of the long name, it might be better to rename the method to >> just `addHandler(...)` and then add a one-liner comment to the method saying >> that the handler consumes the entire request body. > > I'm a big fan of [self-documenting > code](https://en.wikipedia.org/wiki/Self-documenting_code) over comments. > Unless there is a strong objection, I'd like to stick to my long method name. > 😊 I don't have an objection, it's OK to continue with this method name. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26155#discussion_r2244530062
