> Adds a new `ofFileChannel(FileChannel channel, long offset, long length)` > method to `java.net.HttpRequest.BodyPublishers` to provide an `HttpClient` > publisher to upload a certain region of a file. The new publisher does not > modify the state of the passed `FileChannel`, streams the file channel bytes > as it publishes (i.e., avoids reading the entire file into the memory), and > can be leveraged to implement sliced uploads. As noted in the Javadoc: > >> The file channel will not be closed upon completion. The caller is >> expected to manage the life cycle of the channel, and close it >> appropriately when not needed anymore. > > ### Implementation notes > > - `FileChannel` is preferred over `{Readable,Seekable}ByteChannel`, since the > latter does not provide a positional read without modifying the state of the > `FileChannel`, which is necessary to use a single `FileChannel` instance to > implement sliced uploads. > - `ofFileChannel(FileChannel,long,long)` is preferred over > `ofPath(Path,long,long)` to avoid overloading the maximum file descriptor > limit of the platform.
Volkan Yazici has updated the pull request incrementally with six additional commits since the last revision: - Fix typo in `Utils::getBufferWithAtMost` Javadoc - Link to `BUFSIZE` in `Utils::getBuffer` Javadoc - Improve wording for signaling request cancellation - Remove synchronization for `FileChannelIterator` - Improve exception handling and documentation for `ofFileChannel` - Add `@since 26` to `ofFileChannel` ------------- Changes: - all: https://git.openjdk.org/jdk/pull/26155/files - new: https://git.openjdk.org/jdk/pull/26155/files/3af61c5f..da698406 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26155&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26155&range=02-03 Stats: 28 lines in 3 files changed: 9 ins; 9 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/26155.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26155/head:pull/26155 PR: https://git.openjdk.org/jdk/pull/26155