On Fri, 8 Aug 2025 07:34:35 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Can I please get a review of this test-only change which proposes to fix an >> intermittent failure in that test? This addresses >> https://bugs.openjdk.org/browse/JDK-8364786. >> >> As noted in that issue, the test fails because the main thread doesn't wait >> for the server side HttpHandler instances to return from the handle() >> method. There are 2 commits in this PR - one is general clean up and >> additional logging and the second one is the actual fix where we `close()` >> the server side `Executor` before asserting a counter state in the main >> thread. Closing the server side `Executor` waits till the HttpHandler >> instances return from their handle() method and thus prevents these >> intermittent test failures. >> >> The reporter of the JBS issue has tested this proposed fix in their setup >> and the test no longer fails. I have also triggered a test repeat (and tier >> testing) for this change in our CI. > > test/jdk/java/net/vthread/HttpALot.java line 36: > >> 34: import java.util.concurrent.atomic.AtomicInteger; >> 35: import com.sun.net.httpserver.HttpServer; >> 36: import jdk.test.lib.net.URIBuilder; > > Did you mean to move the imports? Just curious as I usually put the test > description at the top to make it easy to find, I guess others prefer it > after the imports. Hello Alan, I will undo that part. I usually prefer the test definition directly above the class declaration. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26686#discussion_r2262185675
