On Fri, 8 Aug 2025 09:02:59 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> test/jdk/java/net/vthread/HttpALot.java line 98: >> >>> 96: // go >>> 97: server.start(); >>> 98: try (serverExecutor) { >> >> This part looks good, as does checking that the task result is "Hello" as >> that adds more checking. > > It would be more correct to close the server executor after server.stop() > returns, to make sure the server will not try to use the executor after it's > closed. Done. I've updated the PR to close the executor after the server is stopped. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26686#discussion_r2262407890