On Fri, 8 Aug 2025 06:52:18 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this test-only change which proposes to fix an > intermittent failure in that test? This addresses > https://bugs.openjdk.org/browse/JDK-8364786. > > As noted in that issue, the test fails because the main thread doesn't wait > for the server side HttpHandler instances to return from the handle() method. > There are 2 commits in this PR - one is general clean up and additional > logging and the second one is the actual fix where we `close()` the server > side `Executor` before asserting a counter state in the main thread. Closing > the server side `Executor` waits till the HttpHandler instances return from > their handle() method and thus prevents these intermittent test failures. > > The reporter of the JBS issue has tested this proposed fix in their setup and > the test no longer fails. I have also triggered a test repeat (and tier > testing) for this change in our CI. This pull request has now been integrated. Changeset: f83454cd Author: Jaikiran Pai <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/f83454cd61538b653656ccf81759b3cc7286ed67 Stats: 33 lines in 1 file changed: 19 ins; 2 del; 12 mod 8364786: Test java/net/vthread/HttpALot.java intermittently fails - 24999 handled, expected 25000 Reviewed-by: dfuchs, alanb, vyazici ------------- PR: https://git.openjdk.org/jdk/pull/26686
