On Sat, 23 Aug 2025 02:17:18 GMT, SendaoYan <s...@openjdk.org> wrote:
>> Currently, take test/jdk/com/sun/nio/sctp/SctpMultiChannel/Branch.java as >> example. When Util.isSCTPSupported() return false, then test print a warning >> and the exit. >> >> I think it's better to throw jtreg.SkippedException rather than only print a >> warning and then report test passed. >> >> Change has been verified locally, test-fix only, almost no risk. > > SendaoYan has updated the pull request incrementally with one additional > commit since the last revision: > > Replace "throw new jtreg.SkippedException" ad "throw new SkippedException" Overall this looks OK to me. I wonder if we could instead have a `@requires` implemented in the JDK repo for the presence of SCTP support. That way all these repeated checks (backed by opening and closing a socket) wouldn't be necessary in the test code. But it's OK in this proposed form for now. I've a trivial review comment which I've added inline. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26903#issuecomment-3243905559
