On Tue, 2 Sep 2025 06:08:12 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Replace "throw new jtreg.SkippedException" ad "throw new SkippedException"
>
> Overall this looks OK to me. I wonder if we could instead have a `@requires` 
> implemented in the JDK repo for the presence of SCTP support. That way all 
> these repeated checks (backed by opening and closing a socket) wouldn't be 
> necessary in the test code. But it's OK in this proposed form for now. I've a 
> trivial review comment which I've added inline.

@jaikiran Thanks for the reviews and suggestions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26903#issuecomment-3245340810

Reply via email to