On Mon, 22 Sep 2025 19:14:39 GMT, Volkan Yazici <vyaz...@openjdk.org> wrote:
>> test/jdk/java/net/httpclient/http2/ConnectionFlowControlTest.java line 265: >> >>> 263: >>> 264: http2TestServerLocal.start(); >>> 265: https2TestServerLocal.start(); >> >> I believe you should revert these changes or make sure they result in >> exactly the same calls. For instance - `http2TestServerLocal.start();` is >> not exactly the same as `this.http2TestServer.start();` - the original code >> was calling start() on the wrapper, and IMO it's better to continue doing >> that. > >> I believe you should revert these changes > > @dfuch, IMHO, the changes are (partially) necessary since the associated > _instance_ variables are switched to _class_ variables, and `this.`-prefixing > and variable shadowing do not work anymore. That said, I agree with your > suggestion that changes should be minimal and functionally equivalent to the > old ones. > >> the original code was calling start() on the wrapper, and IMO it's better to >> continue doing that. > > Agreed. Thanks. now corrected with start() call on wrapper. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27388#discussion_r2372927498
