On Tue, 23 Sep 2025 16:33:49 GMT, Mahendra Chhipa <[email protected]> wrote:
>> Refactoring following httpclient/http2 testng test to JUnit :
>> test/jdk/java/net/httpclient/http2/BadHeadersTest.java
>> test/jdk/java/net/httpclient/http2/BadPushPromiseTest.java
>> test/jdk/java/net/httpclient/http2/BasicTest.java
>> test/jdk/java/net/httpclient/http2/ConnectionFlowControlTest.java
>> test/jdk/java/net/httpclient/http2/ContinuationFrameTest.java
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Implemented the review comments.
Changes requested by vyazici (Committer).
test/jdk/java/net/httpclient/http2/BadHeadersTest.java line 142:
> 140: {https2URI, false, byteAtATime },
> 141: {http2URI, true, byteAtATime },
> 142: {https2URI, true, byteAtATime },
@mahendrachhipa, I'd advise avoiding styling changes, unless it is really
necessary.
test/jdk/java/net/httpclient/http2/ContinuationFrameTest.java line 150:
> 148: {https2URI, false, byteAtATime},
> 149: {http2URI, true, byteAtATime},
> 150: {https2URI, true, byteAtATime},
Again, I'd suggest reverting these.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27388#pullrequestreview-3259142225
PR Review Comment: https://git.openjdk.org/jdk/pull/27388#discussion_r2373119960
PR Review Comment: https://git.openjdk.org/jdk/pull/27388#discussion_r2373124975
