On Tue, 23 Sep 2025 16:15:41 GMT, Josiah Noel <[email protected]> wrote:
>> Josiah Noel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove upgrade
>
>> we should include as part of this fix, some symbolic constants to represent
>> the special (and counter-intuitive) length values of 0 and -1 for
>> sendResponseHeaders
>
> I mean I like this too and would appreciate that as well, but it seems a bit
> unrelated to the current change.
>
>> This method must be called prior to calling {@link #getResponseBody()}.
>
> Hm? I do this all the time though.
@SentryMan Thanks for your patience! I will have a deeper look at your proposed
changes and see how it behave in our CI. I suspect we might want to add some
`@apiNote` to highlight how to send interim responses, and possibly clarify
what the `length` parameter means in this case. Not sure if we should accept
(and ignore) any value that is passed - or request that a specific value is
passed (like 0 or -1) - something to be discussed. Let me review the code -
then we can figure out what kind of note/statement we want to add to the API
documentation.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27069#issuecomment-3324740260
