On Fri, 7 Nov 2025 15:10:39 GMT, Jaikiran Pai <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - More copyright dates
>> - small test cleanup
>> - Fix copyright dates
>
> test/jdk/java/net/httpclient/http3/H3LogHandshakeErrors.java line 126:
>
>> 124: final HttpRequest.Builder reqBuilder =
>> HttpRequest.newBuilder(reqURI)
>> 125: .version(HTTP_3);
>> 126: Logger serverLogger =
>> Logger.getLogger("jdk.httpclient.HttpClient");
>
> Should we add a reachability fence for this `serverLogger`?
Good point. When I started coding I thought it would be used in the finally
block but in the end I forgot about it.
> test/jdk/java/net/httpclient/http3/H3LogHandshakeErrors.java line 153:
>
>> 151: // place where we log the exception from changes.
>> 152: String expectedClassName =
>> QuicConnectionImpl.class.getName()
>> 153: + "$HandshakeFlow";
>
> Would just asserting for the (expected) log message and the presence of
> stacktrace be enough? Irrespective of which class logs it?
Possibly. Let's keep that for now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2504081188
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2504088339
