On Fri, 7 Nov 2025 15:30:20 GMT, Daniel Fuchs <[email protected]> wrote:
>> Surprisingly if the QUIC handshake fails exceptionally, and
>> `-Djdk.httpclient.HttpClient.log=errors` is specified, the exception is not
>> logged. This change fixes that.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review feedback
test/jdk/java/net/httpclient/http3/H3LogHandshakeErrors.java line 151:
> 149: System.out.println("Issuing request: " + req1);
> 150: final HttpResponse<Void> resp1 = client.send(req1,
> BodyHandlers.discarding());
> 151: Assert.assertEquals(resp1.statusCode(), 200, "unexpected
> response code for GET request");
Sorry I missed htis in the previous round of review. Shouldn't this line be a
`fail("Request expected to fail but didn't")`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28196#discussion_r2504537116
