> Can I please get a review for this fix which addresses a connection leak in > HttpClient when dealing with HTTP/2 requests? > > I have added a comment in https://bugs.openjdk.org/browse/JDK-8326498 which > explains what the issue is. The fix here addresses the issue by cleaning up > the `Http2Connection` closing logic and centralizing it to a connection > terminator. The terminator then ensures that the right resources are closed > (including the underlying SocketChannel) when the termination happens. > > A new jtreg test has been introduced which reproduces the issue and verifies > the fix.
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision: - rename method - remove unneeded method - logging and javadoc comment fixes - merge latest from master branch - update test to use h2c HTTP/2 server - fix typo in test code comment - trivial debug log check change - rename isErroneousClose() to isAbnormalClose() - stackless instance for idle timed out NoError - Volkan's suggestion - log message improvement - ... and 9 more: https://git.openjdk.org/jdk/compare/098155bd...c554a521 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28233/files - new: https://git.openjdk.org/jdk/pull/28233/files/f4ed10d9..c554a521 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28233&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28233&range=04-05 Stats: 20731 lines in 292 files changed: 12805 ins; 5674 del; 2252 mod Patch: https://git.openjdk.org/jdk/pull/28233.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28233/head:pull/28233 PR: https://git.openjdk.org/jdk/pull/28233
