On Wed, 12 Nov 2025 09:33:58 GMT, Volkan Yazici <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use Utils.toIOException()
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2TerminationCause.java
> line 176:
>
>> 174: } else {
>> 175: return new IOException(original);
>> 176: }
>
> I presume we don't need to peel off any `CompletionException` and/or
> `ExecutionException`, right?
This is a good point. Given the nature of this method, which can/must get
called for terminating the connection for any failure, it can't be ruled out
that the `original` exception is either a `CompletionException` or
`ExecutionException`. The call sites shouldn't be bothered with doing those
checks, so I've updated the PR to use the pre-existing
`Utils.toIOException(original)` here. I have triggered a new CI run with these
changes (and I don't except it to cause issues).
Separately, I will consider whether we need to do this same thing in the HTTP3
connection termination cause as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2541445265
