On Mon, 17 Nov 2025 12:37:57 GMT, Daniel Jeliński <[email protected]> wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/quic/QuicCubicCongestionController.java
>> line 114:
>>
>>> 112: if (!isAppLimited) {
>>> 113: if (wEstBytes < cwndPriorBytes) {
>>> 114: wEstBytes += Math.max((long) (ALPHA * maxDatagramSize
>>> * packetBytes / congestionWindow), 1);
>>
>> should we assert that congestionWindow is > 2 ?
>
> The congestion window is in bytes, and it's never reduced below
> 2*maxDatagramSize, which is never less than 2400. Not sure if we should add
> that particular assertion, but it would probably make sense to assert that
> packetAcked does not decrease the congestion window. I'll see what I can do.
I added the assertion in the base class
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28195#discussion_r2549159411
