On Mon, 24 Nov 2025 11:33:34 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review for this fix which addresses a connection leak in >> HttpClient when dealing with HTTP/2 requests? >> >> I have added a comment in https://bugs.openjdk.org/browse/JDK-8326498 which >> explains what the issue is. The fix here addresses the issue by cleaning up >> the `Http2Connection` closing logic and centralizing it to a connection >> terminator. The terminator then ensures that the right resources are closed >> (including the underlying SocketChannel) when the termination happens. >> >> A new jtreg test has been introduced which reproduces the issue and verifies >> the fix. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > remove outdated comment Thank you Daniel for the review. Daniel, Volkan @dfuch @vy if this looks OK to you both too, then I'll go ahead and integrate this today. The tier tests continue to pass. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28233#issuecomment-3573290516
