On Mon, 24 Nov 2025 10:50:36 GMT, Daniel Jeliński <[email protected]> wrote:

>> Hello Daniel, my understanding is that the `HttpClient` default 
>> implementation in the JDK will be `jdk.internal.net.http.HttpClientImpl`, 
>> but if these tests are run against any other implementation of the 
>> `HttpClient` then this test is going to fail to find that internal state. If 
>> that isn't a practical concern, then I will go ahead and remove this 
>> skipping of the test.
>
> We don't have similar checks in any of the other whitebox tests, so I think 
> we can safely assume that HttpClientImpl is the only implementation we test.

I agree - this is not a concern. Our tests only test our implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2555878032

Reply via email to