On Mon, 15 Dec 2025 13:54:49 GMT, Matthias Baesken <[email protected]> wrote:

>> src/java.base/unix/native/libnet/net_util_md.c line 288:
>> 
>>> 286:         if (family != java_net_InetAddress_IPv4) {
>>> 287:             if (ipv6av) {
>>> 288:                 JNU_ThrowByName(env, JNU_JAVANETPKG "SocketException", 
>>> "Protocol family ipv6, ipv6 on machine available");
>> 
>> This exception does not really make sense. Are you really sure it's possible 
>> to get here?
>
> Looks like to get into the else case starting at line 284 or before the patch 
> like 282 ,  ipv6_available() / ipv6av can be false ; or also the second part 
> of the if check can be false  
> 
> !(family == java_net_InetAddress_IPv4 &&  v4MappedAddress == JNI_FALSE))
> 
> so we should distinguish the 2 cases. Not sure if this really happens, on our 
> system showing the error we got the other one `Caused by: 
> java.net.SocketException: Protocol family ipv6, ipv6 on machine unavailable`

Or just  write the old message `"Protocol family unavailable" ` for this case 
and enhance the else case ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28825#discussion_r2619583618

Reply via email to