On Mon, 26 Jan 2026 19:33:47 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> replace TestAbortedException with Assumptions.assumeTrue
>
> test/jdk/java/nio/channels/Selector/ConnectionRefusedMessage.java line 91:
>
>> 89: assumeTrue(success, "unexpectedly connected to "
>> + destAddr);
>> 90: }
>> 91: fail("ConnectException was not thrown");
>
> The test is fine, I'm just curious why the assumeTrue is predicated on
> success being true, is this left over from the previous iteration? If it is
> removed then the fail goes away too.
Hello Alan, I got that assumeTrue call wrong in that previous update. What I
really wanted there was to skip the test if finishConnect() returned true (i.e.
if something unexpectedly accepted the connection). The test doesn't expect
finishConnect() to complete normally with a return value of false, and if that
happens then I wanted to fail the test. I've now updated the PR accordingly.
Does this look reasonable?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29409#discussion_r2730647640
