On Tue, 27 Jan 2026 15:55:11 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which proposes to remove the >> confusing "getsockopt" text from the exception reported on Windows when >> `SocketChannel.finishConnect()` raises an exception due to a failed >> `connect()`? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8376290 and as noted in >> that issue, this looks like an oversight when changes were done for >> https://bugs.openjdk.org/browse/JDK-8317603. Prior to that, on older >> versions the exception reported on Windows was: >> >> >> java.net.ConnectException: Connection refused: no further information >> >> >> With the current proposed changes in this PR, the exception will now be >> `java.net.ConnectException: Connection refused` which matches what we report >> on *nix platforms. >> >> A new jtreg test has been added to reproduce the original text and verify >> the change. tier1, tier2 and tier3 continue to pass with this change. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > update code comment in test Thank you Alan and Mark for the reviews. tier1, tier2 and tier3 tests completed normally with this change. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29409#issuecomment-3815752184
