On Tue, 27 Jan 2026 09:59:49 GMT, Daniel Fuchs <[email protected]> wrote:

>> test/jdk/java/net/httpclient/ConnectTimeoutTest.java line 108:
>> 
>>> 106:                                 "Failed creating client socket %s/%s",
>>> 107:                                 (socketIndex + 1), socketCount);
>>> 108:                         throw new RuntimeException(message, ioe);
>> 
>> why not `UncheckedIOException`? alternatively a simple for loop ...
>
> Have you tried to uncondiotionnaly throw an exception here to see how it 
> shows up in the test log? IIRC throwing in static initializer in test classes 
> didn't give very user friendly diagnosis. But I have never seen how it looked 
> like with junit :-)

Just to see if doing this during class initialization is OK - or if we should 
rather move that to a method annotated with `@BeforeAll`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29431#discussion_r2731201132

Reply via email to