On Tue, 27 Jan 2026 14:42:15 GMT, Volkan Yazici <[email protected]> wrote:
>> Fix tests using `AbstractConnectTimeout` by replacing the usage of an >> external host (i.e., `example.com`), which unexpectedly resolves to a real >> IP address on certain test hosts, with a custom `ServerSocket` bootstrapped >> by the test. >> >> The initial PR contains 3 commits: >> >> 1. b06f2606c88 Replace external domain with a custom `ServerSocket` (i.e., >> _"the fix"_) >> 2. b9262c7ca01 Remove the need for multiple test files >> 3. d95a335db93 Migrate tests to JUnit >> >> All commits (i.e., 1, 1+2, and 1+2+3) pass tests. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Apply review feedback It's a bit unfortunate that we don't have a means to test this reliably on windows. Do we really need to allow for backlog + 512 sockets? Can we go with backlog + 8 instead? If we're now using the loopback there should no longer be any "No route to host" or "Unresolved address" exceptions, should it? ------------- PR Review: https://git.openjdk.org/jdk/pull/29431#pullrequestreview-3722287890
