On Thu, 12 Feb 2026 16:09:29 GMT, Jaikiran Pai <[email protected]> wrote:

>> test/jdk/java/net/httpclient/NullReturningBodyHandlerTest.java line 236:
>> 
>>> 234:     }
>>> 235: 
>>> 236:     private record Request(URI reqURI, Version version, boolean 
>>> requiresWarmupHEADRequest) {
>> 
>> I doubt if you need this carrier DTO. All you do is `Arguments.of(new 
>> Request(requestURI, version, ...))` — instead you can simply do 
>> `Arguments.of(requestURI, version, ...)` and change `test(final Request 
>> request)` to `test(String requestURI, ...)`.
>
> It was an effort to keep the method arguments a bit more concise. But I don't 
> have a strong preference. I have updated the test to split those arguments 
> into individual parts.

It was an effort to keep the method arguments a bit more concise. But I don't 
have a strong preference. I have updated the test to split those arguments into 
individual parts.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29691#discussion_r2799753040

Reply via email to