On Thu, 12 Feb 2026 14:47:55 GMT, Volkan Yazici <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - split the test method arguments into individual parts
>> - no need for the duplicate null check
>> - use HttpTestEchoHandler in the new test
>
> test/jdk/java/net/httpclient/NullReturningBodyHandlerTest.java line 231:
>
>> 229: final ExecutionException ee =
>> assertThrows(ExecutionException.class, f::get);
>> 230: if (!(ee.getCause() instanceof IOException cause)
>> 231: || !(cause.getCause() instanceof NullPointerException))
>> {
>
> Would you mind giving this a good shake in the CI, please? Asynchronous
> nature of things can disrupt assumptions on the causal chain of raised
> exceptions.
A test repeat 50 of java/net/httpclient tests came back fine with these changes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29691#discussion_r2802294197
