On Fri, 13 Feb 2026 12:30:30 GMT, Daniel Fuchs <[email protected]> wrote:
>> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java >> line 907: >> >>> 905: long responseLength = useXFixed() >>> 906: ? t.responseLength(bytes.length) >>> 907: : HttpTestExchange.fixedRsp(bytes.length); >> >> was it supposed to use a chunked response when useXFixed is false? > > I have added support for XFixed in this class and I did want subclasses to > "opt-in" for using it, since I did not want to change the behavior of > existing tests. Existing tests use fixed length by default, whether XFixed is > present or not. Without useXFixed() these tests would suddenly get chunked > responses instead, since they don't set the `XFixed: yes` header. ahh, I mixed up `useXFixed` and `rspFixedRequested`. I think I'd prefer to check `useXFixed` in `rspFixedRequested` instead of here. WDYT? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29702#discussion_r2804046604
