On Fri, 13 Feb 2026 12:45:47 GMT, Daniel Jeliński <[email protected]> wrote:
>> I have added support for XFixed in this class and I did want subclasses to >> "opt-in" for using it, since I did not want to change the behavior of >> existing tests. Existing tests use fixed length by default, whether XFixed >> is present or not. Without useXFixed() these tests would suddenly get >> chunked responses instead, since they don't set the `XFixed: yes` header. > > ahh, I mixed up `useXFixed` and `rspFixedRequested`. > > I think I'd prefer to check `useXFixed` in `rspFixedRequested` instead of > here. WDYT? It's not easy because `rspFixedRequested` is defined on the exchange while `useXFixed` is defined on the handler. Tests will subclass `HttpTestHandler` and override `useXFixed` if they want to opt in. They can't easily subclass the exchange, and the exchange doesn't have access to the handler. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29702#discussion_r2804170396
