On Tue, 4 Aug 2026 11:56:02 GMT, Jaikiran Pai <[email protected]> wrote:
>> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java
>> line 1423:
>>
>>> 1421: private void log(final String msg) {
>>> 1422: System.err.println(this.server.name + ": " + msg);
>>> 1423: }
>>
>> You might consider replacing all `printf` et al. usages with invocations to a
>>
>>
>> private static final Logger LOGGER =
>> Utils.getDebugLogger(Http2TestServerConnection.class::getSimpleName)
>>
>>
>> class field.
>
> Did you literally mean `printf` or was this a general comment about replacing
> the usage of `System.err` with the `Logger`? I can't spot any `printf` calls
> in this class.
I've now pushed an update which uses `Utils.getDebugLogger()`. The tests
continue to pass, so it looks like it won't cause any unforeseen issues with
using this logging facility here. I will run a more extensive test repeat in
our CI with this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32173#discussion_r3712320914
