On Wed, 5 Aug 2026 08:48:47 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits since the last revision: >> >> - create the writeLoopThread when the connection is created >> - don't remove the unused reset method >> - merge latest from master branch >> - merge latest from master branch >> - use Utils.getDebugLogger() instead of writing directly to System.err >> - prevent multi-threaded concurrent close resulting in closing more than >> once >> - readLoopThread needn't be a field >> - merge latest from master branch >> - merge latest from master branch >> - missed copyright year updates on a couple more files >> - ... and 3 more: https://git.openjdk.org/jdk/compare/80e3fab1...b753d786 > > test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/BodyOutputStream.java > line 189: > >> 187: } >> 188: sendReset(resetErrorCode); >> 189: } > > Maybe we should keep this method even if it's not used at the moment. > Possibly `Http2TestExchangeImpl::resetStream` should call this instead of > `sendReset`. I've updated the PR to reintroduce this method. It will need a bit more thoughts to decide if we should stop calling `sendReset` from the exchange. I think we could do that in future. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32173#discussion_r3720391009
