On Thu, 27 Aug 2026 09:23:14 GMT, Daniel Fuchs <[email protected]> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Simplify purge instant extraction in `ConnectionPool`
>
> src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java 
> line 347:
> 
>> 345:                     ChronoUnit.MILLIS);
>> 346:         }
>> 347:         return closelist;
> 
> I don't see why this piece of code could not be moved right after calling 
> `purgeExpiredConnections` when obtaining a new deadline is required. It would 
> avoid the ugly long[] parameter.

Right. Simplified as suggested in 127790cdbbb.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32545#discussion_r3878874902

Reply via email to