On Fri, 28 Aug 2026 11:59:20 GMT, Volkan Yazici <[email protected]> wrote:
>> Good point again. Holding the lock while doing this might not be a good >> idea. Now that I think about it, I guess that your reasoning was that the >> event would eventually fire and terminate the connection later? So your >> concern was just to prevent it from being reused? >> >> Then maybe we need to double check that the connection is still idle before >> marking it finalStream. Then just let the event alone and return false and >> the event will eventually fire and do its job. > > b4dc8c03a6c introduces further checks for idleness. > > I've reverted the `volatile` copy, since it is only read & written while the > lock is held. > >> I guess that your reasoning was that the event would eventually fire and >> terminate the connection later? So your concern was just to prevent it from >> being reused? > > Correct. The field is still volatile - so we should read it only once. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32545#discussion_r3881615539
