On Fri, 18 Sep 2026 08:25:08 GMT, Lee Jiwon <[email protected]> wrote:
>> Before this change, Sockets.supportedOptions(Class<?>) used a hard-coded >> option map created during class initialization. The reported set could >> differ from the options supported by an actual socket instance. >> >> This change creates an instance of the requested socket type for each call >> and returns its supportedOptions() result. The temporary socket is closed >> after use, and jdk.net.Sockets does not cache the result. The hard-coded >> option map and helper code used only to build that map are removed. >> >> Testing: >> >> * make test TEST=test/jdk/jdk/net/Sockets/SupportedOptions.java >> * make test TEST=test/jdk/jdk/net/Sockets >> * make test TEST=jdk_net — 1,082 tests passed >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Lee Jiwon has updated the pull request incrementally with one additional > commit since the last revision: > > 8392528: Remove unused checkValueType method src/jdk.net/share/classes/jdk/net/Sockets.java line 266: > 264: } > 265: } catch (IOException e) { > 266: throw new IOError(e); Would an UncheckedIOException be better here? IOError is not used anywhere else in the networking code ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32943#discussion_r4045676616
