Re: RFR: 8392528: jdk.net.Sockets.supportedOptions may differ from the supported options reported by socket instances [v3]

[Lee Jiwon]

On Fri, 18 Sep 2026 14:53:10 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Lee Jiwon has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8392528: Use UncheckedIOException for socket creation failures
>
> test/jdk/jdk/net/Sockets/SupportedOptions.java line 62:
> 
>> 60:     void invalidSocketTypes() {
>> 61:         assertThrows(IllegalArgumentException.class, () -> 
>> Sockets.supportedOptions(null));
>> 62:         assertThrows(IllegalArgumentException.class, () -> 
>> Sockets.supportedOptions(String.class));
> 
> Sockets.supportedOptions doesn't specify how it handles null to testing long 
> standing behavior is okay.

Thanks for confirming. I'll keep the test for the existing null behavior.

> test/jdk/jdk/net/Sockets/SupportedOptions.java line 66:
> 
>> 64: 
>> 65:     @Test
>> 66:     void serverSocketSupportsIpTos() throws Exception {
> 
> The test is now a unit test for Sockets.supportedOptions so I think this one 
> looks a bit out of places. Is it needed? It looks like 
> SocketOpotion/OptionTest.java tests setting IP_TOS on ServerSOcket.

Thanks for pointing this out. I kept it from the original test. Since 
OptionsTest.java already covers setting IP_TOS on ServerSocket, I'll remove it 
and the unused import.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32943#discussion_r4067500293
PR Review Comment: https://git.openjdk.org/jdk/pull/32943#discussion_r4067502223