On Mon, 2 Nov 2026 20:18:26 GMT, Volkan Yazici <[email protected]> wrote:
>> Add unit tests for the `jdk.httpserver` system properties. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains nine commits: > > - Merge remote-tracking branch 'upstream/master' into hsProp > - Add `Host` headers > - Merge remote-tracking branch 'upstream/master' into hsProp > - Merge remote-tracking branch 'upstream/master' into hsProp > - Apply review feedback from > - Merge remote-tracking branch 'upstream/master' into hsProp > - Delete `DrainAmountPropertyTest`, it will be delivered with 8387853 > - Merge remote-tracking branch 'upstream/master' into hsProp > - Add tests for `HttpServer` configuration system properties test/jdk/com/sun/net/httpserver/property/MaxConnectionsPropertyTest.java line 132: > 130: // `assertThrows` expects `SocketException` > to verify disconnect. > 131: // Use `SocketException` to signal EOF. > 132: throw new SocketException("EOF"); Hello Volkan, I don't fully follow this assertThrows call. Should the `assertThrows` only wrap the `connectAndWriteRequest()` call? The `connectAndWriteRequest()` does a new `connect()` and then writes to the socket. Are you seeing a case where the connect followed by the write succeeds without any exception even when the connection limit imposed by the server is reached? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31974#discussion_r4452306239
