On Tue, 3 Nov 2026 13:25:12 GMT, Daniel Fuchs <[email protected]> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix flushing in `MaxRspTimePropertyTest`
>
> test/jdk/com/sun/net/httpserver/property/MaxIdleConnectionsPropertyTest.java 
> line 1:
> 
>> 1: /*
> 
> Does this test open 200 concurrent sockets? I could see it becoming a source 
> of intermittent failures on various platforms. I wonder if we shouldn't 
> simply verify that the property "works" by supplying a reasonable value and 
> verifying the behaviour for that value, and then simply verify the default 
> cases by other means (e.g. retrieving field values through reflection) rather 
> than activating the behaviour.

Implemented in 3dffdcc877d.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31974#discussion_r4467445400

Reply via email to