On Tue, 10 Nov 2026 12:01:20 GMT, Jaikiran Pai <[email protected]> wrote:
>> This PR removes code, which set the default value "net" for the >> "jdk.includeInExceptions" System Property for `jwebserver`. This value is no >> longer recognized. By removing this code `jwebserver` falls back to the >> value set by the security property, which is "hostInfoExclSocket" by default. >> >> Thanks, >> Jonathan >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/IncludeInExceptionsTest.java > line 49: > >> 47: @Test >> 48: public void preservesExplicitValue() { >> 49: System.setProperty("jdk.includeInExceptions", "hostInfo"); > > Hello Jonathan, I believe the other test method will fail if the execution of > these test methods is reordered at runtime by the test engine, because the > other test method expects the system property value to be null. > > On a general note, I think this test class isn't necessary. An appropriate > noreg label on the JBS issue might be enough > https://openjdk.org/guide/#noreg. Please wait to hear from other reviewers > before removing the test though. Hi Jaikiran, Removing the tests sounds good to me here too. I will wait for other feedback 👍 As far as I can tell as long as tests are run sequentially this should be fine? I always set the intended state before the call to `JWebServer.main("--help");` and check it right after. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33815#discussion_r4524693800
