On Tue, 10 Nov 2026 18:45:45 GMT, Volkan Yazici <[email protected]> wrote:

>>> I always set the intended state before the call to 
>>> JWebServer.main("--help"); and check it right after.
>> 
>> That's a good point. My mind overlooked the 
>> `System.clearProperty("jdk.includeInExceptions");` call in the other test 
>> method (I was just focusing on `System.setProperty(...)`). That effectively 
>> means that test methods ordering isn't an issue here. So please ignore that 
>> part of my previous comment. As for the other part, I think not introducing 
>> this test would still be OK.
>
> Agreeing with @jaikiran that we don't really need to test this.
> 
> `JWebServer.java` changes LGTM.

Thanks for the inputs. I removed the tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33815#discussion_r4530940071

Reply via email to