From: "Dave Shield" <[EMAIL PROTECTED]>

> > So is there in the headers something like:
> >     typedef char* addr_t;
>
> Errr... which header is this, please?
> I've had a quick search through the current CVS head and 5.1.x patches code,
> and the 5.1.1 tarball, and can't find any mention of "addr_t" in any of
> the header files.

No, that was a question...., but forgot the questionmark.
I found in the FreeBSD types:
    typedef char* caddr_t

And since I do not know all the platforms, I'd expect some these things
to go to this level of abstraction. (Although it could be that caddr_t is a
posix thingy.)

> But if you want the fixes to make it into 5.1.2, it would be
> extremely useful if you could submit changes against 5.1.2.pre2
> (since that would simplify the task of applying the changes).
>
> And as a general rule, the more focussed a patch, the faster it
> tends to get adopted.   If a patch tweaks whitespace or formatting
> unncessarily, or mixes two or more significant changes, then
> it makes it that much harder to check it.
>
> But we look forward to receiving your contributions....

What I'll do is try to split the current patchset into several targeted fixes:
fixing 64bit types
fixing tcpTables
fixing udptables

First all against 5.1.1, since that is where FreeBSD is currently at.

Then I'll have a go at 5.1.2.pre2...
And see what I can make from that, and if any of my changes survives. :)

--WjW



-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Net-snmp-coders mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to