On Fri, 08 Oct 2004 14:10:25 -0400 Michael wrote:
MJS> Robert Story wrote:
MJS> > MJS> fix bug#1043197 - provide a function to test os version and release
MJS> > MJS> > I don't think this is the right way to do this. I think this should be a
MJS> > configure time test, not a run-time test.
MJS> > MJS> > In addition, adding something like this should really be done the right
MJS> > way, which means it should work for more than one platform, and should
MJS> > go through review on coders.
MJS> MJS> Robert, I believe you suggested something that would take the
MJS> behavior of SO_BSDCOMPAT and the MemShared patches from Fedora
MJS> and apply them in a kernel appropriate fashion.
MJS> There isn't anything today that configures for a specific
MJS> kernel version, nor should there be, within some reason.
MJS> So I for one do not agree that the decision should be made
MJS> during configuring of the source.
Ok, ignore kernel versions. The whole purpose of configure is to determine, before we compile, if specific functionality is available or not. So instead of testing kernel versions, we should test the functionality in question.
Being that linux is open-source, it's conceivable that someone could back/forward port a feature between 2.4 and 2.6, and the hard-coded assumptions in the source wouldn't work.
MJS> Although it has an application specific today to Linux, MJS> I believe that other platforms support uname, and if MJS> they didn't, the netsnmp_os_prematch method is not an MJS> altogether bad way to encapsulate that.
It may not be, but before we introduce a new api into a new release (much less a feature-frozen release), we should make sure we've thought about it and discussed it, *before* we get locked into maintaining the api for backwards compatibility.
I've behaved badly yesterday. My apologies to all.
The function has been removed from the V5-1-patches branch and the main branch.
With Deep Regret, -Mike Slifcak
------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Net-snmp-coders mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
