RS> Let's see..

RS> - fd_event_manager -> external_fd_manager
RS> - netsnmp_external_event_info -> netsnmp_external_fd_info
RS> - netsnmp_dispatch_external_events -> netsnmp_external_fd_read
OK, cool.  Thanks.

RS> Also, you changed the priority such that external events are 
RS> handled before snmp events. The order shouldn't change.

The reason I did this is because snmp_read() didn't return the count of
events left to be processed.  netsnmp_external_fd_read() does do this
so I changed the order.  So before it would actually go loop through the
external fd to check for events even if select() was only notifying you
of an SNMP event (and nothing else).  I wanted to avoid changing
snmp_read()
prototype and fix this bug/anomaly at the same time.  Let me know if you
still want me to revert the order.

RS> In snmptrapd.c you zero writefds twice and execeptfds isn't cleared.

Ahh a bug, good catch.  Thanks.  

RS> I think those are the only problems. However, I also have
suggestions, 
RS> if you are feeling ambitious.

Well I was given about a week to work on this so when I finish the patch
for snmp trap publishing I may take a look.  All the suggestions look 
good to me.
 


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to