On Fri, 2005-06-10 at 18:20, Robert Story wrote:
> I should mentioned this earlier, and I don't know if this affects any of your
> functions names, but we also agreed that naming based on 'class' before
> 'functionality' was a good thing too.
Yes - I remember. I had that principle in mind when choosing the
original names. So
iquery_get_session
was a more specific (session-based) version of
iquery_get
Unfortunately, I kept misreading this first call as being
"get an iquery session" (which is why I said that I wasn't
happy with the names!)
I think the current distinction of
netsnmp_get vs netsnmp_iquery_get
is much less confusing.
That was the guiding principle behind choosing the original names.
(or at least some of them)
> I don't konw that I'd go as far as to say that we made it a rule,
> but it's certainly my strong preference.
I presume you're suggesting
netsnmp_iquery_session_pdu
netsnmp_iquery_session_user
netsnmp_iquery_session_community
rather than the current routines?
> DS> All routines have been renamed with "netsnmp_" prefixes, and
> DS> the session-based interfaces are now in the main SNMP library.
>
> sigh. I really hate to see more new code go into snmp_(client|api).
In general, I totally agree.
You may remember that I wasted a year trying to restructure the
library code into something more sensible.
But in this particular case, the 'netsnmp_get' API group *do* feel
like "client-convenience" routines, and snmp_client.c seems the
correct place for them. I'd probably want to move much of the rest
of that file elsewhere, but these particular routines belong there IMO.
> Any chance I could talk you into a new file?
I'd rather not create a new file, only to see it become redundant when
we finally get round to a proper library restructuring. Particularly
since the CVS Web view doesn't remove files when they're deleted
from CVS tree. The snmplib directory is cluttered enough already!
Dave
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
