>>>>> On Wed, 02 Nov 2005 13:57:23 +0000, Dave Shield <[EMAIL PROTECTED]> said:
Dave> This comprised two basic tests - these being: Dave> - does the default configuration compile successfully? I've always argued that that's not a fair test. We should be determining if the most common code fails that test, not just the default build. If 99% of our users used embedded perl, EG, but we still didn't enable it by default then it's our fault for not enabling it by default. Also, if SNMP GETs were broken for a certain major handler (say iterator code) in the core code but it still compiled and tested successfully (which doesn't test the iterator code), would you really consider releasing the package? Saying that we're going to ship it broken because fixing it wouldn't meet our release criteria then we'd not be doing a service to our users. It's impossible to define a concrete set of rules that will solve every possible problem we'll face at release time. That's why we've been doing '+3 voting' instead, as it: 1) means we can still follow the rough guidelines but do "what's right" when needed. 2) does a better job of forcing peer-review for those last minute changes, and more importantly does a better job of determining when they should or shouldn't go in. That being said, I'm sort of on the fence about whether the embedded perl support falls on the critical line. It is on by default in our RPMs but not Fedora's, for example. I don't think it is used by "most of our users". However, I've analyzed the patch extensively (having wrote it) and it's very self-contained. The patch to snmp_perl.c is trivial because that file is only complied if turned on in the first place. The configure.in patch is a bit more questionable, since that's a very core file. But the code is only executed iff [sic] embedded perl was requested. So after all that... I'm still on the fence. Read more mail coming soon to a -coders list near you. -- Wes Hardaker Sparta, Inc. ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
