On Tue, 14 Feb 2006 16:27:54 +0000 Dave wrote: DS> On Fri, 2006-02-10 at 19:39 -0500, Robert Story wrote: DS> > http://sourceforge.net/tracker/index.php?func=detail&aid=711465&group_id=12694&atid=112694 DS> > DS> > I'm hoping that Dave can take a look at this, since he was working on a DS> > fix for the original bug report. DS> DS> Can you give me an executive summary, please Robert.
Did you check the summary in the patch? I was rather verbose. Maybe that's why you asked for an 'executive' summary. I'll try to make it shorter. - override handler works *after* the fact. original handler is called and returns data. - bulk_to_next handler advances to next variable if data was returned. didn't check if data was out of range. - check_getnext_results noticed the override after the fact, set type to retry, and set the inclusive flag. - instance handler will return the object queried (ala get) for a get-next request. - bulk_to_next uses 1 request obj w/multiple varbinds. once the inclusive flag is set by check_get_next_results, it's never cleared. These all combined to cause the issues noted in the original bug (original & overridden data returned w/getbulk, and the endless loop I found while testing table instance overrides (Radek's test case). The patch fixes both cases. The only part that I'm a little worried about is the inclusive flag changes. [I'll suppress the rant on how I want to totally gut the agent processing code and make it into something more understandable and easy to follow. At least until the next time I get sucked in that code.] -- Robert Story; NET-SNMP Junkie Support: <http://www.net-snmp.org/> <irc://irc.freenode.net/#net-snmp> Archive: <http://sourceforge.net/mailarchive/forum.php?forum=net-snmp-coders> You are lost in a twisty maze of little standards, all different. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
