On 08/08/06, Robert Story <[EMAIL PROTECTED]> wrote:
> DS> Log Message:
> DS> Remove broken assertion (Bug #1399370)
>
> Actually, I'd rather it stay, unless it's actually causing problems.

Yes, it did - that's why I found it.
(I can't remember the details now - this bug is six months old!)

>                                                             Bad asn
> builds really really shouldn't happen, and iirc, there is no useful error
> message logged when it does happen

So why not just log an error?
Raising an assertion means that the agent crashes out completely.

The man page for "assert" says:
      The  purpose  of this macro is to help the programmer find bugs in his
       program.  The  message  "assertion  failed  in  file  foo.c,  function
       do_bar(), line 1287" is of no help at all to a user.

I'm not convinced that assertions are appropriate for released code.
Log errors, yes - but don't force a crash.

Dave

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to