Robert Story wrote: > I have a few concerns with this patch. > > One is side-effects. In particular, all these breaks and returns are changing > code paths.
Only if klookup() fails. I've added proper error handling for exactly two reasons: 1) It was missing before (which hardly feels good). 2) It was requested. I'm trying to meet the objections raised by my earlier patch. > The other is, is there really any benefit here? While it allows one to remove > --enable-mini-agent, it will just enable a bunch of code that isn't going to > do anything, right? Why does a broken nlist/klookup require > --enable-mini-agent? It it because some modules that use those APIs don't > properly ifdef when those functions aren't available? If so, it seems like > fixing those modules would be cleaner than including a bunch of code that > isn't going to do anything. Adjusting the existing #ifdef hell of those modules feels like much more risk (to me at least) than the straightforward job of adding error handling the way I've done. But I'll be trying to implement whatever the consensus is, as long as we're not keeping things as broken as they are. Comments highly appreciated. +Thomas -- Thomas Anders (thomas.anders at blue-cable.de) ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
