Wes Hardaker wrote:
>>>>>> "RS" == Robert Story <[EMAIL PROTECTED]> writes:
> 
> RS> [...] it seems like fixing those
> RS> modules would be cleaner than including a bunch of code that isn't
> RS> going to do anything.

Still, klookup involves system calls (lseek and read on /dev/kmem, usually) that
potentially could fail any time. Handling potential errors looks like the Right
Thing To Do. We've also fixed Coverity bugs in the past even for
unlikely-to-be-followed code paths.

If you prefer not to, at the moment, no problem: just (re-)consider my earlier
minimal patch that only fixes the build error at hand.

> The one thing that I
> think it might be worth doing for is so that you can at least compile
> everything and you may find some of the objects in the code file do
> work even if they all don't because KLOOKUP is used for some of the
> data.

The difference between --enable-mini-agent and the default module list is *much*
larger than the list of modules that use nlist/klookup at all. E.g. AIX 5.x has
full working host mib support, even on 64-bit, so forcing them to use
--enable-mini-agent will drop a lot.


+Thomas

-- 
Thomas Anders (thomas.anders at blue-cable.de)

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to